Dockerfile and Docker compose

ros2 / ros1_bridge

ROS 2 package that provides bidirectional communication between ROS 1 and ROS 2

Apache License 2.0

449 stars 287 forks source link

Dockerfile and Docker compose #384

Closed yaruchyo closed 1 year ago

yaruchyo commented 1 year ago

use Dockerfile to simply create a new container with ros_1 bridge

quarkytale commented 1 year ago

Please sign your commits for DCO check to pass. You can do so by adding "-s" flag while creating the commit.

methylDragon commented 1 year ago

Several comments:

I'm not sure I see the point of this PR, especially if the dockerfile is going to get pinned to a certain version of ROS.
Furthermore the dockerfile isn't installed anyway, which means a user is required to have access to the source code to use the dockerfile, in which case, why not make it a README or doc section?
Also, I think your IDE added a gitignore file that you might want to remove

methylDragon commented 1 year ago

@yaruchyo I'm going to close this PR. If you'd like, you can make a new PR where the dockerfile is a part of the docs as an example usage, and we can re-review

:fire: :raised_hands: