search

ros2 / ros2

The Robot Operating System, is a meta operating system for robots.
https://docs.ros.org
3.44k stars 656 forks source link

Fix C++17 Deprecation Warnings on MSVC #1123

Open wjwwood opened 3 years ago

wjwwood commented 3 years ago

While working on the first pull request to use c++17 in rclcpp (https://github.com/ros2/rclcpp/pull/1598) I found that turning on c++17 on Windows (using MSVC) produced many, many warnings.

In order to make progress on that pull request I disabled the warnings as the warnings themselves suggested with this commit:

https://github.com/ros2/rclcpp/pull/1598/commits/ac4b35c773c39028b932396b999b1105dbab125a

I think we should triage them, at the very least, between the Galactic API freeze and the Galactic release, so I'll add this (for now) to the Galactic project.

wjwwood commented 3 years ago

Also, I put this here, rather than on rclcpp, because the warnings came from many different packages, not just rclcpp.