ros2 / ros2_documentation

ROS 2 docs repository
https://docs.ros.org/en/rolling
Creative Commons Attribution 4.0 International
552 stars 1.07k forks source link

Polish the ROS 1 -> 2 CMake instructions (backport #4767) #4777

Closed mergify[bot] closed 1 month ago

mergify[bot] commented 1 month ago

This updates the CMake portion of the ROS 1 to ROS 2 guide, and fixes one bug in the C++ code

C++ bug fix: use ->publish( instead of .publish(

I have tried out all steps of the example part of the guide to make sure they work.


This is an automatic backport of pull request #4767 done by Mergify.

mergify[bot] commented 1 month ago

Cherry-pick of 9d6552c00bbc0407ded15a5d48a36f3c03261afb has failed:

On branch mergify/bp/humble/pr-4767
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 9d6552c0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   source/How-To-Guides/Migrating-from-ROS1/Migrating-CPP-Packages.rst

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

github-actions[bot] commented 1 month ago

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/11111508749/artifacts/1996950139.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4777/index.html in your favorite browser