Closed Crola1702 closed 2 weeks ago
Do we know roughly when these tests started failing?
Ah I see why they're failing. They probably never passed.
The test_tracetools
tests in Iron are simply run against the default rmw
implementation. Each test is run once, without RMW_IMPLEMENTATION
being set explicitly: https://github.com/ros2/ros2_tracing/blob/b7235059b677eb69f04f640ea305ff4bc5e46119/test_tracetools/CMakeLists.txt#L133-L157. The other rmw
implementations are not fully instrumented in Iron and the default rmw
implementation for Iron (and Jazzy) is rmw_fastrtps_cpp
, so running tests against the other rmw
implementations will fail (except maybe for rmw_cyclonedds_cpp
).
The simplest fix for Iron here is to skip the tests if the "current" rmw
implementation is not rmw_fastrtps_cpp
.
See #132 for Iron.
I'll need to do the same for rmw_fastrtps_dynamic_cpp
in Jazzy, see Jci__nightly-fastrtps-dynamic_ubuntu_noble_amd64#43. rmw_connextdds
in Jazzy is instrumented.
This was fixed for Iron in #132 and Jazzy in #134, so I'm closing this.
Description
These tests have been failing for a long time in Iron connext and fastrtps-dynamic.
Reference builds:
Test regressions:
All three contain the same log output:
Log output: