search

ros2 / ros2cli

ROS 2 command line interface tools
Apache License 2.0
182 stars 162 forks source link

Add --group and --port options to ros2 multicast #770

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

This PR allows specifying --group and --port to ros2 multicast. This is useful when debugging issues with multicast traffic for a specific group and domain id.

sloretz commented 2 years ago

While you are in here, would you mind augmenting the tests in https://github.com/ros2/ros2cli/blob/rolling/ros2multicast/test/test_api.py to test out the group, port, and TTL arguments?

I updated test_api.py to test group and port arguments in 0ff9423. I wasn't able to think of a way to test ttl here.

sloretz commented 2 years ago

CI (build: --packages-up-to ros2multicast test: --packages-select ros2multicast)

sloretz commented 2 years ago

Converted to draft to prevent merging while I figure out windows issue

sloretz commented 2 years ago

CI re-run