search

ros2 / ros2cli

ROS 2 command line interface tools
Apache License 2.0
182 stars 162 forks source link

Mark test verb load, list and dump as xfail #773

Closed Crola1702 closed 1 year ago

Crola1702 commented 2 years ago

In this issue: https://github.com/ros2/ros2cli/issues/630, is reported an issue with this test on Humble, and @sloretz commented that the solution in https://github.com/ros2/ros2cli/pull/652, cannot be backported.

As this issue is happening just on galactic, I'm marking the following tests as xfail:

Reference build: https://build.ros2.org/view/Gci/job/Gci__nightly-debug_ubuntu_focal_amd64/179/

Running CI:

The commit from @Blast545 didn't mark the test as xfail. This PR also reverts that commit

Crola1702 commented 2 years ago

New CI marking TestCase subclass as xfail:

Crola1702 commented 1 year ago

New CI:

Crola1702 commented 1 year ago

I think it still runs the tests: https://build.ros2.org/job/Gpr__ros2cli__ubuntu_focal_amd64/20/consoleFull#console-section-167 (Check ros2param test section)

FYI: @cottsay

Actually, they didn't run on CI build of the last comment. But they ran on https://build.ros2.org/job/Gpr__ros2cli__ubuntu_focal_amd64/20/. I'll fix the flake8 stuff in the next vcommit (again)

Crola1702 commented 1 year ago

New CI:

cottsay commented 1 year ago

Actually, they didn't run on CI build of the last comment. But they ran on https://build.ros2.org/job/Gpr__ros2cli__ubuntu_focal_amd64/20/.

PR and release builds always run all tests. I think that xfail only applies to CI builds on build.ros2.org and all builds on ci.ros2.org.