search

ros2 / ros2cli

ROS 2 command line interface tools
Apache License 2.0
172 stars 161 forks source link

Fix network aware node issue #785

Closed ivanpauno closed 1 year ago

ivanpauno commented 1 year ago

Fixes https://github.com/ros2/ros2cli/issues/736. https://github.com/ros2/ros2cli/commit/1195df07b48b048fee255ea83160c43275b785be fixes an issue introduced in https://github.com/ros2/ros2cli/pull/652. See https://github.com/ros2/ros2cli/issues/736#issuecomment-1200673304. https://github.com/ros2/ros2cli/commit/77c5f6c20f1f35881505db5f9d553a71646a6e5f corrects how netifaces is being used (improves the checking it's being done).

ivanpauno commented 1 year ago
fujitatomoya commented 1 year ago

@ivanpauno do we want to backport this to humble? i think it would be helpful for user experience.

ivanpauno commented 1 year ago

Yes, let's wait one week to see if nightlies are still green, I will backport then.

ivanpauno commented 1 year ago

@mergifyio backport humble

mergify[bot] commented 1 year ago

backport humble

✅ Backports have been created

* [#786 Fix network aware node issue (backport #785)](https://github.com/ros2/ros2cli/pull/786) has been created for branch `humble`