search

ros2 / ros2cli

ROS 2 command line interface tools
Apache License 2.0
172 stars 161 forks source link

Update the ros2cli test fixture to C++17. #789

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

The main reason to do this is so that we can compile the fixture with the clang static analyzer. As of clang++-14 (what is in Ubuntu 22.04), the default still seems to be C++14, so we need to specify C++17 so that new things in the rclcpp headers work properly.

Further, due to reasons I don't fully understand, I needed to set CMAKE_CXX_STANDARD_REQUIRED in order for clang to really use that version. So set this as well.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

clalancette commented 1 year ago

CI:

clalancette commented 1 year ago

CI was green, so going ahead and merging despite the failed Rpr tests.