search

ros2 / ros2cli

ROS 2 command line interface tools
Apache License 2.0
172 stars 161 forks source link

test_echo_pub.TestROS2TopicEchoPub.test_pub_maxwait_yields failed often recently #809

Closed iuhilnehc-ynos closed 1 year ago

iuhilnehc-ynos commented 1 year ago

Bug report

log on CI for Linux

Error Message
test_echo_pub.TestROS2TopicEchoPub.test_pub_maxwait_yields failed
Stacktrace
======================================================================================================================================================
FAIL: test_echo_pub.TestROS2TopicEchoPub.test_pub_maxwait_yields
------------------------------------------------------------------------------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins-agent/workspace/ci_linux/ws/install/launch_testing/lib/python3.10/site-packages/launch_testing/markers.py", line 57, in _wrapper
    return func(self, *args, **kwargs)
  File "/home/jenkins-agent/workspace/ci_linux/ws/src/ros2/ros2cli/ros2topic/test/test_echo_pub.py", line 258, in test_pub_maxwait_yields
    assert future.done()
AssertionError: assert False
 +  where False = <bound method Future.done of <rclpy.task.Future object at 0x7f1dd13c2500>>()
 +    where <bound method Future.done of <rclpy.task.Future object at 0x7f1dd13c2500>> = <rclpy.task.Future object at 0x7f1dd13c2500>.done

https://ci.ros2.org/job/ci_linux/18139/testReport/junit/ros2topic.ros2topic.test/test_echo_pub/test_echo_pub/ https://ci.ros2.org/job/ci_linux/18137/testReport/junit/ros2topic.ros2topic.test/test_echo_pub/test_echo_pub/ https://ci.ros2.org/job/ci_linux/18133/testReport/junit/ros2topic.ros2topic.test/test_echo_pub/test_echo_pub/ https://ci.ros2.org/job/ci_linux/18129/testReport/ros2topic.ros2topic.test/test_echo_pub/test_echo_pub/ https://ci.ros2.org/job/ci_linux/18128/testReport/junit/ros2topic.ros2topic.test/test_echo_pub/test_echo_pub/ https://ci.ros2.org/job/ci_linux/18126/testReport/junit/ros2topic.ros2topic.test/test_echo_pub/test_echo_pub/

fujitatomoya commented 1 year ago

@iuhilnehc-ynos this is happening because of https://github.com/ros2/ros2cli/pull/800?

iuhilnehc-ynos commented 1 year ago

I think so, but I haven't dived into the deep.

fujitatomoya commented 1 year ago

@Crola1702 @Blast545 CCed.

iuhilnehc-ynos commented 1 year ago

The message can't be reliable to receive without a correct QoS setting if a message is only published once (-t 1). I am going to change the -t 1 with -t 10.

Crola1702 commented 1 year ago

FYI: @arjo129