search

ros2 / ros2cli

ROS 2 command line interface tools
Apache License 2.0
172 stars 161 forks source link

Set automatically_declare_parameters_from_overrides in DirectNode. #813

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

Otherwise, the 'use_sim_time' parameter we are setting here is completely ignored.

@fujitatomoya FYI, this is a follow-up to #581

fujitatomoya commented 1 year ago

Note: we need to backport this to humble.

fujitatomoya commented 1 year ago

CI:

clalancette commented 1 year ago

The failed test on Windows has nothing to do with this PR, so I'll go ahead and merge it.

clalancette commented 1 year ago

@Mergifyio backport humble

mergify[bot] commented 1 year ago

backport humble

✅ Backports have been created

* [#815 Set automatically_declare_parameters_from_overrides in DirectNode. (backport #813)](https://github.com/ros2/ros2cli/pull/815) has been created for branch `humble`