Open Guillaumebeuzeboc opened 1 year ago
implementation looks good to me but many tests are failing.
could you address the following failures?
I had the same failure with the HEAD of rolling for this repo. I had to rebuild all rolling from source for them to pass. I believe the CI is using the debians of rolling right? I pulled all the repo from HEAD.
I believe the CI is using the debians of rolling right?
Yes, that's correct, though as of yesterday, they are the same thing. That said, these tests have indeed been flaky here for a while, and we haven't had time to track it down. So I wouldn't worry about those two in particular right now.
Does that PR require further changes?
Does that PR require further changes?
Yes, we need to come to a conclusion on this discussion.
Adds the
--clear/-c
option to echo.Solves this issue: https://github.com/ros2/ros2cli/issues/725
This was previously available in ROS.
This clears the screen before a new message is displayed.
ESC[2J
corresponds toerase entire screen
ESC[H
corresponds tomoves cursor to home position (0, 0)
I had to build rolling from source to successfully run the tests