search

ros2 / ros2cli

ROS 2 command line interface tools
Apache License 2.0
173 stars 159 forks source link

Backport timeout options on humble #855

Open tokoro10g opened 11 months ago

tokoro10g commented 11 months ago

Feature request

Feature description

Implementation considerations

Is there any policy for backporting? My opinion is that these basic tools should have the same interface across the distributions until it reaches the EOL. What do you say?

fujitatomoya commented 11 months ago

you can see https://docs.ros.org/en/rolling/How-To-Guides/Package-maintainer-guide.html#backporting-to-released-distributions as guideline.

AFAIK, it also depends on the behavior change that could affect the application, tools and so on.

adding command line options can be considered as behavior change. but on this one, i do not see any of that, so it would be probably okay to go? that is not i am 100% sure, so lets keep this open for more feedback.

Related PRs,

CC: @ros2/team @clalancette @wjwwood @audrow

tokoro10g commented 11 months ago

Thank you for the consideration!

I would also like these backported:

They also looked straightforward and not breaking anything. I have not checked all the options, though.

clalancette commented 11 months ago

Is there any policy for backporting? My opinion is that these basic tools should have the same interface across the distributions until it reaches the EOL. What do you say?

The general policy is to only backport as things are requested, and as feasible. Because of our strong API and ABI guarantees in the core, backports are often non-trivial (though they tend to be easier with Python).

For the ones you've requested:

@tokoro10g if you'd like to backport these (keeping the current API), we'd be happy to review them