search

ros2 / ros2cli

ROS 2 command line interface tools
Apache License 2.0
166 stars 158 forks source link

flake8: DeprecationWarning: SelectableGroups dict interface is deprec… #868

Closed fujitatomoya closed 8 months ago

fujitatomoya commented 8 months ago

…ated.

address https://github.com/ros2/ros2cli/issues/867

fujitatomoya commented 8 months ago

CC: @clalancette @iuhilnehc-ynos

iuhilnehc-ynos commented 8 months ago

How about updating the pytest.ini to filter the warning?

diff --git a/pytest.ini b/pytest.ini
index 2fb26a8..9d367c8 100644
--- a/pytest.ini
+++ b/pytest.ini
@@ -2,3 +2,5 @@
 junit_family=xunit2
 timeout=900
 timeout_method=thread
+filterwarnings=ignore:SelectableGroups:DeprecationWarning
clalancette commented 8 months ago

I have no idea if the python3-flake8 in the jammy will remove the warning or not.

I suspect not. It's been there for 2 years, so I don't think that it is going to be fixed in Ubuntu until 24.04.

clalancette commented 8 months ago

How about updating the pytest.ini to filter the warning?

I think we should try doing this to see if it works. That will just make it easier to remove the filter for Ubuntu 24.04.

fujitatomoya commented 8 months ago

@iuhilnehc-ynos @clalancette pytest.ini just does the magic. requesting approval.

fujitatomoya commented 8 months ago

CI: