Closed mergify[bot] closed 4 months ago
This breaks ros2cli on some Unices due to a high soft-limit, https://github.com/ros2/ros2/issues/1531
This PR follows Ruby's approach of reading ~/proc/self/status~ to get fdsize for the loop-limit (as suggested by @clalancette in the bug-report).
Tested this on the latest osrf/ros:rolling-desktop.
Edit: (lmk what I need to do to fix the ci).
CI:
https://ci.ros2.org/job/ci_linux/21209/#showFailuresLink, linux security tests are unstable, these tests are not related to the fix for ros2 daemon spawning process.
852 remove inheritence of open fds to fix the issue. It use the soft-limit from RLIMIT_NOFILE to loop over all fds.
This breaks ros2cli on some Unices due to a high soft-limit, https://github.com/ros2/ros2/issues/1531
This PR follows Ruby's approach of reading ~/proc/self/status~ to get fdsize for the loop-limit (as suggested by @clalancette in the bug-report).
Tested this on the latest osrf/ros:rolling-desktop.
Edit: (lmk what I need to do to fix the ci).
This is an automatic backport of pull request #888 done by Mergify.