search

ros2 / ros2cli

ROS 2 command line interface tools
Apache License 2.0
173 stars 160 forks source link

ros2cli.node.daemon : try getting fdsize from /proc for open fd limit (backport #888) #908

Closed mergify[bot] closed 4 months ago

mergify[bot] commented 4 months ago

852 remove inheritence of open fds to fix the issue. It use the soft-limit from RLIMIT_NOFILE to loop over all fds.

This breaks ros2cli on some Unices due to a high soft-limit, https://github.com/ros2/ros2/issues/1531

This PR follows Ruby's approach of reading ~/proc/self/status~ to get fdsize for the loop-limit (as suggested by @clalancette in the bug-report).

Tested this on the latest osrf/ros:rolling-desktop.

Edit: (lmk what I need to do to fix the ci).

This is an automatic backport of pull request #888 done by Mergify.

fujitatomoya commented 4 months ago

CI:

fujitatomoya commented 4 months ago

https://ci.ros2.org/job/ci_windows/21931/ is unrelated