search

ros2 / ros_astra_camera

ROS wrapper for Astra camera
9 stars 12 forks source link

Added color frame and allowed setting frames via parameters #21

Closed Kukanani closed 7 years ago

Kukanani commented 7 years ago

The color_frame_id_ field is not properly initialized now that old parameter loading code has been commented out. This causes issues when depth registration is enabled, since in that case, the color frame ID is assigned to the depth image.

This commit adds default values for both frames, and also allows both to be set via parameters in the same way as other parameters added recently.

mikaelarguedas commented 7 years ago

Thanks, Here is CI:

mikaelarguedas commented 7 years ago

All green :green_heart: :green_heart: , feel free to "Squash and Merge" this whenever