Closed clalancette closed 6 years ago
I think it was fine to have all the STREAM macros defined for completeness. We don't use ROS_FATAL either but didnt remove it from the shim file
I think it was fine to have all the STREAM macros defined for completeness. We don't use ROS_FATAL either but didnt remove it from the shim file
Actually, I did remove it now :). All of the other packages where we have these shims only define the shims that are needed, so I figured following that same pattern was good.
Actually, I did remove it now :)
Oh I missed that, :+1:
Thanks for the review! Merging.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org