search

ros2 / ros_astra_camera

ROS wrapper for Astra camera
9 stars 12 forks source link

Switch to using the RCUTILS_* macros. #25

Closed clalancette closed 6 years ago

clalancette commented 6 years ago

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

clalancette commented 6 years ago

CI:

mikaelarguedas commented 6 years ago

I think it was fine to have all the STREAM macros defined for completeness. We don't use ROS_FATAL either but didnt remove it from the shim file

clalancette commented 6 years ago

I think it was fine to have all the STREAM macros defined for completeness. We don't use ROS_FATAL either but didnt remove it from the shim file

Actually, I did remove it now :). All of the other packages where we have these shims only define the shims that are needed, so I figured following that same pattern was good.

mikaelarguedas commented 6 years ago

Actually, I did remove it now :)

Oh I missed that, :+1:

clalancette commented 6 years ago

Thanks for the review! Merging.