ros2 / ros_astra_camera

ROS wrapper for Astra camera
9 stars 12 forks source link

Flag included in class initializer list #9

Closed SecretaryBirds closed 7 years ago

SecretaryBirds commented 7 years ago

The depthregistration flag was never initialized, but used during execution, so the behavior was flaky since the value was unpredictable.

fixes this issue #8

Kukanani commented 7 years ago

Could you please remove the CMakeLists addition to make the commit more atomic? #10 should fix multiple CMake issues, including the one you addressed here.

SecretaryBirds commented 7 years ago

Done and done.