search

ros2 / rosbag2

Apache License 2.0
273 stars 246 forks source link

[jazzy] Small cleanups to the rosbag2 tests. (backport #1792) #1793

Closed mergify[bot] closed 3 weeks ago

mergify[bot] commented 1 month ago
  1. Rename "wait_for_srvice_to_be_ready" to "wait_for_service_to_be_ready".
  2. Make some of the constants constexpr, so we no longer have to capture them.
    This is an automatic backport of pull request #1792 done by Mergify.
MichaelOrlov commented 3 weeks ago

Pulls: ros2/rosbag2#1793 Gist: https://gist.githubusercontent.com/MichaelOrlov/b1d0577680a1fd33b7a1a8cd998040ca/raw/6b8e7103bb97cedf403fc206a6ef5170163ee216/ros2.repos BUILD args: --packages-above-and-dependencies rosbag2_transport rosbag2_test_common rosbag2_tests TEST args: --packages-above rosbag2_transport rosbag2_test_common rosbag2_tests ROS Distro: jazzy Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14513

MichaelOrlov commented 3 weeks ago

The new warnings on the Linux-rhel

rti_build_helper.cmake:380
no CONNEXTDDS_DIR nor NDDSHOME specified

Is unrelated, and I believe it is due to some infrastructure issue. Merging then.