ros2 / rosbag2

Apache License 2.0
285 stars 251 forks source link

Allow unknown types in bag rewrite #1812

Closed MichaelOrlov closed 1 month ago

MichaelOrlov commented 2 months ago

This PR will allow ros2 bag convert to process bag files with "unknown" message types. Unknown are the types which typesupport is not available during the bag conversion operation.

Also added proper handling for the ament_index_cpp::PackageNotFoundError exception throwing from the ament_index_cpp::get_package_share_directory(package);. It was causing abnormal converter or recorder termination if the package for message definition was not found in ament_index.

ahcorde commented 1 month ago

Pulls: ros2/rosbag2#1812 Gist: https://gist.githubusercontent.com/ahcorde/7de0137f97a41986a0f805eb1abf597c/raw/c9e33724e3d5fda265a4e3a6eb2de990528518eb/ros2.repos BUILD args: --packages-above-and-dependencies rosbag2_cpp --packages-above-and-dependencies rosbag2_cpp TEST args: --packages-above rosbag2_cpp --packages-above rosbag2_cpp ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14593

MichaelOrlov commented 1 month ago

https://github.com/Mergifyio backport jazzy iron humble

mergify[bot] commented 1 month ago

backport jazzy iron humble

✅ Backports have been created

* [#1817 Allow unknown types in bag rewrite (backport #1812)](https://github.com/ros2/rosbag2/pull/1817) has been created for branch `jazzy` * [#1818 Allow unknown types in bag rewrite (backport #1812)](https://github.com/ros2/rosbag2/pull/1818) has been created for branch `iron` but encountered conflicts * [#1819 Allow unknown types in bag rewrite (backport #1812)](https://github.com/ros2/rosbag2/pull/1819) has been created for branch `humble` but encountered conflicts