ros2 / rosbag2

Apache License 2.0
285 stars 251 forks source link

[jazzy] Allow unknown types in bag rewrite (backport #1812) #1817

Closed mergify[bot] closed 1 month ago

mergify[bot] commented 1 month ago

This PR will allow ros2 bag convert to process bag files with "unknown" message types. Unknown are the types which typesupport is not available during the bag conversion operation.

Also added proper handling for the ament_index_cpp::PackageNotFoundError exception throwing from the ament_index_cpp::get_package_share_directory(package);. It was causing abnormal converter or recorder termination if the package for message definition was not found in ament_index.

MichaelOrlov commented 1 month ago

Pulls: ros2/rosbag2#1817 Gist: https://gist.githubusercontent.com/MichaelOrlov/ace05c3f65eddcf20c30cda9e7a62878/raw/8e7d4c193090d4bfa4ea9efb9a5b08777445b438/ros2.repos BUILD args: --packages-above-and-dependencies rosbag2_cpp TEST args: --packages-above rosbag2_cpp ROS Distro: jazzy Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14597