mergify[bot]
commented
1 month ago Cherry-pick of cd7bd63696604973e23c739afa6387556f3e7781 has failed:
On branch mergify/bp/iron/pr-1812
Your branch is up to date with 'origin/iron'.
You are currently cherry-picking commit cd7bd636.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Changes to be committed:
modified: rosbag2_cpp/test/rosbag2_cpp/test_local_message_definition_source.cpp
modified: rosbag2_transport/src/rosbag2_transport/bag_rewrite.cpp
Unmerged paths:
(use "git add <file>..." to mark resolution)
both modified: rosbag2_cpp/src/rosbag2_cpp/message_definitions/local_message_definition_source.cpp
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
ahcorde
MichaelOrlov
This PR will allow
ros2 bag convertto process bag files with "unknown" message types. Unknown are the types which typesupport is not available during the bag conversion operation.Also added proper handling for the
ament_index_cpp::PackageNotFoundErrorexception throwing from theament_index_cpp::get_package_share_directory(package);. It was causing abnormal converter or recorder termination if the package for message definition was not found in ament_index.This is an automatic backport of pull request #1812 done by Mergify.