ros2 / rosbag2

Apache License 2.0
285 stars 251 forks source link

[humble] Allow unknown types in bag rewrite (backport #1812) #1819

Closed mergify[bot] closed 1 month ago

mergify[bot] commented 1 month ago

This PR will allow ros2 bag convert to process bag files with "unknown" message types. Unknown are the types which typesupport is not available during the bag conversion operation.

Also added proper handling for the ament_index_cpp::PackageNotFoundError exception throwing from the ament_index_cpp::get_package_share_directory(package);. It was causing abnormal converter or recorder termination if the package for message definition was not found in ament_index.

mergify[bot] commented 1 month ago

Cherry-pick of cd7bd63696604973e23c739afa6387556f3e7781 has failed:

On branch mergify/bp/humble/pr-1812
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit cd7bd636.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   rosbag2_transport/src/rosbag2_transport/bag_rewrite.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
    deleted by us:   rosbag2_cpp/src/rosbag2_cpp/message_definitions/local_message_definition_source.cpp
    deleted by us:   rosbag2_cpp/test/rosbag2_cpp/test_local_message_definition_source.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

ahcorde commented 1 month ago

Pulls: ros2/rosbag2#1819 Gist: https://gist.githubusercontent.com/ahcorde/4ccbe11bcf40d06d514db7a2fcc4e54b/raw/01a94c416a6c6226589f83e1fe58c2d1f809adce/ros2.repos BUILD args: --packages-above-and-dependencies rosbag2_cpp --packages-above-and-dependencies rosbag2_cpp TEST args: --packages-above rosbag2_cpp --packages-above rosbag2_cpp ROS Distro: humble Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14603

ahcorde commented 1 month ago

warning on windows is not related with this PR