mergify[bot]
commented
1 month ago Cherry-pick of a269cd4106e25bce316c8fde10cdce06467a1339 has failed:
On branch mergify/bp/humble/pr-1823
Your branch is up to date with 'origin/humble'.
You are currently cherry-picking commit a269cd4.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Changes to be committed:
modified: rosbag2_cpp/include/rosbag2_cpp/converter_interfaces/serialization_format_converter.hpp
modified: rosbag2_cpp/include/rosbag2_cpp/converter_interfaces/serialization_format_deserializer.hpp
modified: rosbag2_cpp/include/rosbag2_cpp/converter_interfaces/serialization_format_serializer.hpp
renamed: rosbag2_cpp/src/rosbag2_cpp/rmw_implemented_serialization_format_converter.hpp -> rosbag2_cpp/include/rosbag2_cpp/rmw_implemented_serialization_format_converter.hpp
modified: rosbag2_cpp/package.xml
modified: rosbag2_cpp/src/rosbag2_cpp/converter.cpp
modified: rosbag2_cpp/src/rosbag2_cpp/rmw_implemented_serialization_format_converter.cpp
modified: rosbag2_cpp/src/rosbag2_cpp/serialization_format_converter_factory_impl.hpp
new file: rosbag2_cpp/test/rosbag2_cpp/test_serialization_converter.cpp
Unmerged paths:
(use "git add <file>..." to mark resolution)
both modified: rosbag2_cpp/CMakeLists.txt
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
MichaelOrlov
This PR will address default rmw-implemented serialization converter failures when deserializing messages from the CDR format with rmw_fastrtps.
This PR addresses the issue described in the https://github.com/ros2/rosbag2/issues/1815
RCA and fix proposal please see in the https://github.com/ros2/rosbag2/issues/1815#issuecomment-2367116368
The fix uses rmw-specific type support for rmw_serilize{deserialize} function calls instead of the introspection type support. Note: It is ok for CycloneDDS and ConnextDDS to use introspection type support for rmw_serilize{deserialize} functions. However, for FastRTPS it must be rmw specific type support. e.g.
rosidl_typesupport_cpp. The fix should work for CycloneDDS, ConnextDDS and FastRTPS RMWs.This is an automatic backport of pull request #1814 done by Mergify.
This is an automatic backport of pull request #1823 done by Mergify.