search

ros2 / rosbag2

Apache License 2.0
285 stars 251 forks source link

Rename rclpy.qos.QoS*Policy to rclpy.qos.*Policy #1832

Closed christophebedard closed 3 weeks ago

christophebedard commented 1 month ago

Just a simple change. Although these names were not deprecated, they were renamed in https://github.com/ros2/rclpy/pull/379.

fujitatomoya commented 1 month ago

Pulls: ros2/rosbag2#1832 Gist: https://gist.githubusercontent.com/fujitatomoya/bd1cd9aaaa7a0a6d2fbcc3fd78b006fd/raw/5338f29b39e16f898fceef0b024ad3cf6ed5419e/ros2.repos BUILD args: --packages-above-and-dependencies rosbag2 TEST args: --packages-above rosbag2 ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14698

fujitatomoya commented 1 month ago

However, I am curious how tests were passing with renamed from rclpy.qos import QoSDurabilityPolicy?

for not breaking the downstream packages, we have an alias for retroccompatibility.

https://github.com/ros2/rclpy/blob/a09a0312cf9e2bbe0f6dc4467c72060a2fb74ce5/rclpy/rclpy/qos.py#L410

christophebedard commented 1 month ago

Yes, these were still working because there are aliases. And using those aliases does not trigger deprecation warnings.

MichaelOrlov commented 1 month ago

Re-run Windows CI build

MichaelOrlov commented 3 weeks ago

https://github.com/Mergifyio backport jazzy

mergify[bot] commented 3 weeks ago

backport jazzy

✅ Backports have been created

* [#1841 Rename rclpy.qos.QoS*Policy to rclpy.qos.*Policy (backport #1832)](https://github.com/ros2/rosbag2/pull/1841) has been created for branch `jazzy`