search

ros2 / rosbag2

Apache License 2.0
285 stars 251 forks source link

[jazzy] Bugfix: Update metadata with new file_info before saving it the first time in the file (backport #1843) #1853

Closed mergify[bot] closed 1 week ago

mergify[bot] commented 1 week ago

This PR is a bug fix for missing file_info for newly created file in saved metadata.

When we are switching to new storage, the correct behavior shall be as follows:

  1. Save metadata to storage
  2. Close current storage
  3. Open new storage for read_write
  4. Update metadata with a newly created file
  5. Save metadata to storage
    This is an automatic backport of pull request #1843 done by Mergify.
MichaelOrlov commented 1 week ago

Pulls: ros2/rosbag2#1853 Gist: https://gist.githubusercontent.com/MichaelOrlov/628bd3ec71b6285489fe85cb11f17aaf/raw/5796bc669ffb763364608256f084c9fd8f2fd8ad/ros2.repos BUILD args: --packages-above-and-dependencies rosbag2_compression rosbag2_cpp rosbag2_tests TEST args: --packages-above rosbag2_compression rosbag2_cpp rosbag2_tests ROS Distro: jazzy Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14798