search

ros2 / rosbag2_bag_v2

rosbag2 plugin for replaying ros1 version2 bag files
Apache License 2.0
24 stars 4 forks source link

CMake only logs warning when roscpp is not found #13

Closed piraka9011 closed 4 years ago

piraka9011 commented 4 years ago

When CMake want's to find the roscpp package, it currently only logs a warning. Since rosbag_v2 depends on roscpp, the build should fail and not skip.

wjwwood commented 4 years ago

I don't think we want this, because otherwise we'll have to remove this package or otherwise disable it when building without ROS 1 (a common practice).

If you want to change this to an error I think you should also move this package into a separate repository.

wjwwood commented 4 years ago

Oh sorry, this is already a separate repository. And it's not in the main ros2.repos file, so that should be ok. Sorry for the noise.