search

ros2 / rosbag2_bag_v2

rosbag2 plugin for replaying ros1 version2 bag files
Apache License 2.0
24 stars 4 forks source link

Use rosbag2 metapackage #16

Closed zmichaels11 closed 4 years ago

zmichaels11 commented 4 years ago

Changes

Blocked on https://github.com/ros2/rosbag2/issues/253 since play e2e test is failing.

zmichaels11 commented 4 years ago

@Karsten1987 does this PR need CI to merge? Dpr and Epr are failing due to unrelated changes.

Karsten1987 commented 4 years ago

The same comment applies here: https://github.com/ros2/rosbag2/pull/254#issuecomment-574449206

zmichaels11 commented 4 years ago

Building with ci_packaging Repos file https://gist.githubusercontent.com/zmichaels11/543a323a0b3788054a44899fc4eecfd5/raw/b983d85e735c80a1cca3ab36e3a3ae2839c07224/ros2.repos CI Build Args --event-handlers console_cohesion+ console_package_list+ --cmake-args -DINSTALL_EXAMPLES=OFF -DSECURITY=ON --packages-up-to rosbag2_bag_v2_plugins CI_MIXED_ROS_OVERLAY_PKGS ros1_bridge rosbag2_bag_v2_plugins ros1_rosbag_storage_vendor CI Test Args --event-handlers console_direct+ --executor sequential --retest-until-pass 10 --packages-select rosbag2_bag_v2_plugins

Build status

zmichaels11 commented 4 years ago

All tests passed on Linux CI, going to kick off CI for other OS's

zmichaels11 commented 4 years ago

I ran CI with packaging on all OS. Linux and Linux ARM64 are running properly. They're marked unstable due to a deprecation warning in ros1_bridge: "Package 'actionlib_msgs' is deprecated"

macOS packaging reports as passing, however it stopped after building the underlay. Windows packagin reports as unstable and didn't finish building the underlay. (It didn't `packages-skip ros1_bridge like Linux/Linux ARM64 did)

@Karsten1987 what do you think should be done?