Raise an error instead of a warning without ROS 1

ros2 / rosbag2_bag_v2

rosbag2 plugin for replaying ros1 version2 bag files

Apache License 2.0

25 stars 4 forks source link

Raise an error instead of a warning without ROS 1 #23

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

When ROS 1 roscpp and the ros1_bridge are not installed, this can't actually build.

Closes #13

Please see the brief conversation in #13 for more info - basically there's no reason to pretend to succeed, since this is not part of the standard ros2.repos

Karsten1987 commented 4 years ago

I guess I don't have a strong reason why this change shouldn't be okay.