search

ros2 / rosbag2_bag_v2

rosbag2 plugin for replaying ros1 version2 bag files
Apache License 2.0
24 stars 4 forks source link

Add caching to testing workflow #27

Closed piraka9011 closed 4 years ago

piraka9011 commented 4 years ago

Signed-off-by: Anas Abou Allaban aabouallaban@pm.me

thomas-moulard commented 4 years ago

This won't save time because APT will try to install the packages anyway, and this will corrupt APT internal state, so I would not recommend this approach. What is the problem you're trying to address here?

piraka9011 commented 4 years ago

What is the problem you're trying to address here?

It was an attempt to speed up the build process while trying to get rosbag2_bag_v2to build. Looks like a Docker based solution/action instead might be a better approach.

thomas-moulard commented 4 years ago

+1 on this. We could also cache the APT cache which would be slightly better, but it's still a tricky path. Skipping the setup stage altogether with a Docker image would indeed be guaranteed to work.