search

ros2 / rosbag2_bag_v2

rosbag2 plugin for replaying ros1 version2 bag files
Apache License 2.0
24 stars 4 forks source link

Prepare for bloom release 0.1.0 #41

Closed emersonknapp closed 3 years ago

Karsten1987 commented 3 years ago

The rolling releases are failing due to a lack of ROS1.

23:10:32 -- Checking for module 'roscpp'
23:10:32 --   No package 'roscpp' found
23:10:32 CMake Error at CMakeLists.txt:28 (message):
23:10:32   Failed to find ROS 1 roscpp, cannot build.
23:10:32 
23:10:32 
23:10:32 -- Configuring incomplete, errors occurred!

The fix is to cherry-pick the following changes onto the rolling release branches: https://github.com/ros2-gbp/rosbag2_bag_v2-release/pulls?q=is%3Apr+is%3Aclosed

@emersonknapp let me know if you want me to take care of it. A new bloom-release is not needed.

emersonknapp commented 3 years ago

Yeah @Karsten1987 would you mind taking it on? I'm trying to figure out the foxy fast-forward situation at the moment - the PR builder won't accept the branch if it's not a true fast-forward, so i have to rebase the master stuff onto the diverged foxy commits, i think