Expect EXIT_FAILURE when storage id is not present

ros2 / rosbag2_bag_v2

rosbag2 plugin for replaying ros1 version2 bag files

Apache License 2.0

24 stars 4 forks source link

Open Karsten1987 opened 3 years ago

Karsten1987 commented 3 years ago

as per title

emersonknapp commented 3 years ago

Based on the title of this test - maybe it should also be EXPECT_NO_THROW?

MichaelOrlov commented 3 years ago

@Karsten1987 Am I understand correctly that rational for this changes is the same as I have described in https://github.com/ros2/rosbag2/pull/763?

If so, it looks like we need to change the test name as well. We are not handling exceptions and not exiting gracefully anymore.