search

ros2 / rosbag2_bag_v2

rosbag2 plugin for replaying ros1 version2 bag files
Apache License 2.0
25 stars 4 forks source link

release to humble #47

Open christian-rauch opened 2 years ago

christian-rauch commented 2 years ago

The plugin has not been released to humble yet:

$ sudo apt install -y ros-humble-rosbag2-bag-v2-plugins
[...]
E: Unable to locate package ros-humble-rosbag2-bag-v2-plugins
clalancette commented 2 years ago

The main issue here is that lack of a supported ROS 1 distribution on Humble, so we can't actually build it.

We could potentially link this against the version of rosbag(1) that is shipped in Ubuntu 22.04, but someone would need to do the work to add the right rosdep keys to https://github.com/ros/rosdistro, fix any problems with building, and test it out.

christian-rauch commented 2 years ago

I see, the rosbag plugin needs released packages from ROS1? I had a look at https://github.com/ros2/rosbag2_bag_v2/blob/master/rosbag2_bag_v2_plugins/package.xml and https://github.com/ros2/rosbag2_bag_v2/blob/master/ros1_rosbag_storage_vendor/package.xml, but those appear to be ros2 packages.

In any case, ysing the ros packages in the official Ubuntu repo would be one option. But this would only work until Debian/Ubuntu drops the ros packages, e.g. in the next version. Could we import the necessary source files into this repo, so it is self-contained? Or can we continue to release the necessary ros1 packages to new Ubuntu versions?

clalancette commented 2 years ago

But this would only work until Debian/Ubuntu drops the ros packages, e.g. in the next version.

My understanding is that as long as there are interested packagers, the ROS 1 packages will continue to be released into Debian/Ubuntu. These are not officially supported by Open Robotics, but it does seem like it will be viable to depend on them for the foreseeable future.

christian-rauch commented 2 years ago

Are all required packages available in the official Ubuntu 22.04 repo? I am trying to compile this from source. After installing libroscpp-dev manually it is still missing ros1_rosbag_storage, which is neither a ros1 package in Ubuntu (https://packages.ubuntu.com does not show a result) nor a ros2 package (rosdep does not try to install it).

clalancette commented 2 years ago

Are all required packages available in the official Ubuntu 22.04 repo?

I'm not sure, sorry.

emersonknapp commented 2 years ago

I feel like importing the rosbag2_bag2 format parsing libraries could be a pretty safe option at this point. The format has finalized, and there will be no more (officially supported) releases of ROS 1, so those libraries aren't updating. In order to reduce dependencies, it would make a lot of sense in my opinion to just port that C++ ROS1 bag libary to be a package that can be built for this tool to use.