search

ros2 / rosidl

Packages which provide the ROS IDL (.msg) definition and code generation.
Apache License 2.0
76 stars 125 forks source link

Update check-copied-type-description-sources.yaml #762

Closed mosfet80 closed 1 year ago

mosfet80 commented 1 year ago

Updated tj-actions

emersonknapp commented 1 year ago

This is fine... but was it necessary? Just interested in any context for why an update might be needed.

clalancette commented 1 year ago

@mosfet80 Can you please rebase and add a "Signed-off-by" line to your commit? Once that is done we can go ahead with this.

mosfet80 commented 1 year ago

V37 introduces support for using Github's REST API to retrieve the list of changed files without requiring the checkout action. V36 introduces

performance improvements: We've made significant enhancements to glob filtering which resulted in over 60% faster execution times, with more improvements on the horizon.

Verbose logging: We now provide detailed logs to help you better understand what's happening behind the scenes.

Clean abstractions/maintainability: Our new architecture is more modular and easier to maintain.

Reduced complexity: All functionality is now managed in this project, making it easier for you to use and understand.

Improved output file storage: We've made it easier to store output files for further processing.

Globstar patterns now work as expected **.js would match all .js files

clalancette commented 1 year ago

@mosfet80 It's going to be easiest if you rebase for the Signed-off-line. Something like:

$ git checkout rolling-1
$ git rebase rolling
$ git commit --amend -s