search

ros2 / rosidl

Packages which provide the ROS IDL (.msg) definition and code generation.
Apache License 2.0
75 stars 125 forks source link

Address #775: Really make `char` in python a `str` #781

Closed arjo129 closed 3 months ago

arjo129 commented 8 months ago

This commit addresses #775 for rolling going forward.

Note: This commit breaks a lot of down stream tests. I will be pushing fixes one by one as I discover errors.

sloretz commented 8 months ago

The fix here looks good to me! Let me know when they're ready and I'll review them all at once.

clalancette commented 8 months ago

While I think this is the right thing to do, this is probably going to cause some heartache on downstream consumers.

To that end, I think we should be loud about the change. So I'll request that you please open up a PR to update http://docs.ros.org/en/rolling/Releases/Release-Jazzy-Jalisco.html with details of this change so that users who are switching to Jazzy are aware.

arjo129 commented 3 months ago

I don't think this change is worth it as downstream users will be left with a lot of "busy work"