search

ros2 / rosidl

Packages which provide the ROS IDL (.msg) definition and code generation.
Apache License 2.0
76 stars 125 forks source link

Add types to definition.py in `rosidl_parser` #791

Closed InvincibleRMC closed 2 weeks ago

InvincibleRMC commented 7 months ago

Adding types to defintion.py to solve warnings raised in https://github.com/ros2/rosidl_python/pull/206 and improve readability.

sloretz commented 2 weeks ago

@mergifyio update

mergify[bot] commented 2 weeks ago

update

✅ Branch has been successfully updated

sloretz commented 2 weeks ago

Pulls: https://github.com/ros2/rosidl/pull/791 Gist: https://gist.githubusercontent.com/sloretz/2c0fe5761de1071f7ded2b57f31a82d9/raw/c5235f4fdd81c7d9d5e27a042385ff870be0cee4/ros2.repos BUILD args: --packages-above-and-dependencies rosidl_parser TEST args: --packages-above rosidl_parser ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14723

sloretz commented 2 weeks ago

Thank you for the PR!