search

ros2 / rosidl_dds

Apache License 2.0
6 stars 7 forks source link

fix generated idl for static arrays of non-primitive types #22

Closed dirk-thomas closed 9 years ago

jacquelinekay commented 9 years ago

before I test, can you clarify if this is a fix for https://github.com/ros2/rosidl/issues/26? I am confused because https://github.com/ros2/rosidl/pull/27 presents a workaround but the title of this suggests it is a fix.

dirk-thomas commented 9 years ago

No, this patch fixed the generated .idl files.

ros2/rosidl#26 is about generating C code from the ROS .msg / .srv files.

wjwwood commented 9 years ago

+0 it's not clear at all why this is needed, but I assume it's ok.

dirk-thomas commented 9 years ago

Double colon in a type name are invalid in IDL.

jacquelinekay commented 9 years ago

+1 when I confirm https://github.com/ros2/rosidl_dds/pull/23 works

tfoote commented 9 years ago

+1