search

ros2 / rosidl_python

rosidl support for Python
Apache License 2.0
20 stars 45 forks source link

Fixing generated import order #173

Closed quarkytale closed 2 years ago

quarkytale commented 2 years ago

The sorting order for the module names changes after the call to convert_camel_case_to_lower_case_underscore. So copied the converted names to another variable and sorting those final names before writing to the file. See #171 for details.

sloretz commented 2 years ago

When you run CI, I'd recommend running tests on --packages-above rosidl_generator_py. That will make sure we run linter tests on all the downstream interface packages.

quarkytale commented 2 years ago

ci_linux Build Status

quarkytale commented 2 years ago
quarkytale commented 2 years ago

@mergifyio backport galactic

mergify[bot] commented 2 years ago

backport galactic

✅ Backports have been created

* [#175 Fixing generated import order (backport #173)](https://github.com/ros2/rosidl_python/pull/175) has been created for branch `galactic`
quarkytale commented 2 years ago

@Mergifyio backport humble

mergify[bot] commented 2 years ago

backport humble

✅ Backports have been created

* [#183 Fixing generated import order (backport #173)](https://github.com/ros2/rosidl_python/pull/183) has been created for branch `humble`