search

ros2 / rosidl_python

rosidl support for Python
Apache License 2.0
20 stars 45 forks source link

Change decode mode into replace. #176

Closed fujitatomoya closed 2 years ago

fujitatomoya commented 2 years ago

address https://github.com/ros2/rclpy/issues/881

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

fujitatomoya commented 2 years ago

@iuhilnehc-ynos could you do review when you have time?

fujitatomoya commented 2 years ago

CI:

fujitatomoya commented 2 years ago

@clalancette CI is unstable, are we having any problems on CI?

iuhilnehc-ynos commented 2 years ago

@fujitatomoya

I think @clalancette had already fixed it in this PR(https://github.com/ros2/ci/pull/677).

fujitatomoya commented 2 years ago

CI retry:

fujitatomoya commented 2 years ago

@Mergifyio backport humble galactic foxy

mergify[bot] commented 2 years ago

backport humble galactic foxy

✅ Backports have been created

* [#179 Change decode mode into replace. (backport #176)](https://github.com/ros2/rosidl_python/pull/179) has been created for branch `humble` * [#180 Change decode mode into replace. (backport #176)](https://github.com/ros2/rosidl_python/pull/180) has been created for branch `galactic` * [#181 Change decode mode into replace. (backport #176)](https://github.com/ros2/rosidl_python/pull/181) has been created for branch `foxy`