Install compiled libraries only to 'lib'

ros2 / rosidl_python

rosidl support for Python

Apache License 2.0

20 stars 45 forks source link

Install compiled libraries only to 'lib' #195

Closed cottsay closed 1 year ago

cottsay commented 1 year ago

The current behavior results in duplicate libraries installed to both the Python module in libdir and also into the global lib directory for the prefix.

The former seems unnecessary, so we should install the libraries only to lib.

cottsay commented 1 year ago

Linux
Linux-aarch64
Windows

brta-jc commented 1 year ago

Bump. Any updates or plan for this?

cottsay commented 1 year ago

Bump. Any updates or plan for this?

Yep:

I think we need to do some more extensive testing on this

By all means, if you're interested in seeing this merged, please test it and provide feedback.

clalancette commented 1 year ago

I've updated this to the latest, and also removed what I think are now unnecessary macros. Here's a large set of CI to see what happens:

Linux
Linux-aarch64
Windows
Windows Debug
RHEL
Clang

clalancette commented 1 year ago

All right, the extensive CI is actually really happy with this. So I'm going to go ahead and merge this in, since it seems to be an improvement, and doesn't seem to have downsides. After a few days in source, I'll likely also do a release of this just to be sure the buildfarm is happy with it as well.