search

ros2 / rosidl_python

rosidl support for Python
Apache License 2.0
19 stars 45 forks source link

Improve message types. #206

Open InvincibleRMC opened 4 months ago

InvincibleRMC commented 4 months ago

Adds some static typing to generated messages. Built off #205.

InvincibleRMC commented 4 months ago

Still need to fix a circular import issue.

InvincibleRMC commented 3 months ago

Running mypy complains about the type change within @property this doesn't effect the end user and is fine for now until #mypy300 gets resolved.

haudren-woven commented 1 month ago

Very nice! There is another working package here: https://github.com/rospypi/rosidl_generator_mypy

I hope this can be merged and replace the above :pray: Thank you for working on type annotations.

InvincibleRMC commented 1 month ago

Very nice! There is another working package here: https://github.com/rospypi/rosidl_generator_mypy

I hope this can be merged and replace the above 🙏 Thank you for working on type annotations.

If your solutions works and gets merged in I will gladly close this pr.

haudren-woven commented 1 month ago

Actually our solution is meant as a placeholder which you can use in your own workspace without modifying rosidl_generator_py. Last time we tried to PR this in, the maintainers did not seem to have much interest in merging it, but I'm supportive to merge your solution in: I'd rather focus our contributions on a core package such that it can benefit the larger community. From my cursory look, they look rather equivalent so let's go with it :+1: