search

ros2 / rosidl_python

rosidl support for Python
Apache License 2.0
20 stars 45 forks source link

Revert install of .so files into python path #211

Closed ghost closed 5 months ago

ghost commented 5 months ago

There seems that some regression might have happened after #195. When removing those 2 lines, we avoid to install the .so files in lib and python path.

clalancette commented 5 months ago

There seems that some regression might have happened after #195. When removing those 2 lines, we avoid to install the .so files in lib and python path.

Can you explain the regression? We haven't been seeing that in our testing, so I'm curious what is happening.

ghost commented 5 months ago

Hi @clalancette ,

sure. When you build for example builtin-interfaces, you will get /usr/lib/libbuiltin_interfaces__rosidl_generator_py.so and /usr/lib/python3.12/site-packages/builtin_interfaces/libbuiltin_interfaces__rosidl_generator_py.so which are essentially providing the same stuff. The later one is not needed and just bloats the packages.

ghost commented 5 months ago

Note that it was removed in #195 but sneaked in again later with 1505ac07675800c8259ae40df3421177ce0eb17a

clalancette commented 5 months ago

Note that it was removed in #195 but sneaked in again later with 1505ac0

Ah, thanks for the explanation. You are right, it did sneak back in. Here is CI to see if this works everywhere:

clalancette commented 5 months ago

Both of the failing tests here are known issues, so I'm going to go ahead and merge this one. Thanks for fixing this again.