search

ros2 / rosidl_python

rosidl support for Python
Apache License 2.0
20 stars 45 forks source link

[backport] Use modern cmake targets to avoid absolute paths to appear in binary … #214

Closed xueying4402 closed 3 weeks ago

xueying4402 commented 4 months ago

…archives (#160)

sloretz commented 3 weeks ago

Thank you for the PR, and for your patience! I'm going to close this backport for now because I don't feel confident that it won't break someone's workflow.

@sloretz What's your take on this one?

I think my main concern is that Python3 CMake module could find a different version of NumPy than the current custom logic in rosidl_generator_py. I think that could break a non-standard Python setup like a venv. While ROS 2 doesn't directly support those, I've seen bugs opened by people using different non-standard Python setups for other platforms.