search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

Remove type_support_dispatch.cpp files. #101

Closed clalancette closed 3 years ago

clalancette commented 3 years ago

They don't actually add any code, since they only #include a header file with a templated function in them.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

I think what happened here is that these files used to contain the implementation of find_library_path, get_env_var, etc. PR #47 moved that functionality out of these files and into the rcpputils package, but didn't remove the (now empty) .cpp files. This PR just finishes cleaning them up.

clalancette commented 3 years ago

Full CI, just to make sure there isn't some side effect I don't understand:

clalancette commented 3 years ago

The test failures for all of the yellow builds are all in the nightlies (and most of them are already fixed). So this is ready for review.