Give files in bin/ executable permissions

[ijnek]

Getting permission denied errors when building ROS2 rolling from source, as below. This adds executable permissions to files in bin/

Starting >>> rosgraph_msgs                    
--- stderr: rosgraph_msgs                      
make[2]: execvp: /home/ijnek/ros2_rolling/install/rosidl_typesupport_c/lib/rosidl_typesupport_c/rosidl_typesupport_c: Permission denied
make[2]: *** [CMakeFiles/rosgraph_msgs__rosidl_typesupport_c.dir/build.make:70: rosidl_typesupport_c/rosgraph_msgs/msg/clock__type_support.cpp] Error 127
make[1]: *** [CMakeFiles/Makefile2:467: CMakeFiles/rosgraph_msgs__rosidl_typesupport_c.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
---
Failed   <<< rosgraph_msgs [9.58s, exited with code 2]

Similar to https://github.com/ros2/rosidl_typesupport_fastrtps/pull/77

[clalancette]

Same comment as https://github.com/ros2/rosidl_typesupport_fastrtps/pull/77#issuecomment-897597540

[christophebedard]

I'm getting a similar error all of a sudden:

Starting >>> builtin_interfaces
--- stderr: builtin_interfaces
make[2]: execvp: /root/ws/install/rosidl_typesupport_cpp/lib/rosidl_typesupport_cpp/rosidl_typesupport_cpp: Permission denied
make[2]: *** [CMakeFiles/builtin_interfaces__rosidl_typesupport_cpp.dir/build.make:69: rosidl_typesupport_cpp/builtin_interfaces/msg/duration__type_support.cpp] Error 127
make[1]: *** [CMakeFiles/Makefile2:578: CMakeFiles/builtin_interfaces__rosidl_typesupport_cpp.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
---
Failed   <<< builtin_interfaces [4.50s, exited with code 2]

This is my own nightly CI from last night. I'm also seeing it in action-ros-ci-based CI: https://github.com/ros2/rosbag2/runs/3311661112#step:3:12916

Could it be related to this? #116 / https://github.com/ros2/rosidl_typesupport/commit/5d539269f1928c4397eb06c399d68af2329b4920

[clalancette]

Could it be related to this? #116 / 5d53926

Seems unlikely; we merged that 3 days ago. I'm not sure what is going on yet.

[christophebedard]

It's probably https://github.com/ros2/rosidl/pull/612, see https://github.com/ros2/rosidl/pull/612#issuecomment-897408341.

[mjcarroll]

https://github.com/ros2/rosidl/pull/615

[sloretz]

Looks like this is implicitly using PythonInterp. I don't know why this wasn't found by ros2/rosidl#612's CI

https://github.com/ros2/rosidl_typesupport/blob/5d539269f1928c4397eb06c399d68af2329b4920/rosidl_typesupport_c/cmake/rosidl_typesupport_c_generate_interfaces.cmake#L74

[mjcarroll]

This is resolved by https://github.com/ros2/rosidl_typesupport/pull/118, thanks for reporting.