search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

Use FindPython3 in typesupport packages #118

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

Alternative to https://github.com/ros2/rosidl/pull/615

I think with both https://github.com/ament/ament_cmake/pull/355 and https://github.com/ros2/rosidl/pull/612 being merged yesterday, two sources of packages internally calling find_package(PythonInterp) got removed, but their CI's were run at different times. This replaces the implicit PythonInterp dependency with an explicit finding of Python3.

sloretz commented 2 years ago

Short Windows CI to get a quick answer (build: --packages-up-to builtin_interfaces test: --packages-select rosidl_typesupport_c rosidl_typesupport_cpp builtin_interfaces) Build Status

Full CI for a complete answer

sloretz commented 2 years ago

Short windows CI again, this time including https://github.com/ros2/rosidl_typesupport_fastrtps/pull/78: Build Status

Full CI again, this time including https://github.com/ros2/rosidl_typesupport_fastrtps/pull/78

emersonknapp commented 2 years ago

I'm surprised the nightly linux didn't break - I can't get builds to succeed for message packages

clalancette commented 2 years ago

I'm surprised the nightly linux didn't break - I can't get builds to succeed for message packages

Yes, for reasons I don't understand, it seems to be different for different people. It's working fine for me locally, for instance, and it also worked on Linux and macOS on https://ci.ros2.org/view/nightly/. Regardless, the full CI we are running now should show whether it works on all platforms.

sloretz commented 2 years ago

Windows CI has two test failures not in the previous CI job https://ci.ros2.org/view/nightly/job/nightly_win_rel/2022/#showFailuresLink

projectroot.test_buffer_client_tester.launch.py
test_tf2.TestBufferClient.test_termination

But that's a lot better than failing to build, so I'll merge these PRs.