Misc rosidl_typesupport cleanup

[sloretz]

This cleans up the rosidl generator code in the packages rosidl_typesupport_c and rosidl_typesupport_cpp

• rosidl_typesupport_c only
  • Remove redundant visibility header https://github.com/ros2/rosidl_typesupport/pull/123#discussion_r827483497
• rosidl_typesupport_cpp only
  • Add missing dependency on rcutils
• rosidl_typesupport_c and rosidl_typesupport_cpp
  • Replace ament_target_dependencies with target_link_libraries() ament/ament_cmake#292
  • use DEFINE_SYMBOL for setting the compiler definition that toggles the visibility export macros.
  • Depend on the target generated by rosidl_generator_c or rosidl_generator_cpp, instead of hard coding include directories that they're going to create
  • When depending on another interface package, depend only on the target this generator created for that interface package instead of depending on all targets
  • Make sure to ament_export_dependencies() the packages needed by generated targets
  • Remove _generator_sources check that can't work because other CMake code would error if it were ever actually empty

depends on ros2/rosidl#666 Merged :tada: depend on ros2/rosidl#662 Merged :tada:

[sloretz]

@hidmic I added you as a reviewer, but this one seems to depend on https://github.com/ros2/rosidl/pull/662 so I've left it as a draft until that one is merged.

[sloretz]

CI (build: --packages-above-and-dependencies rosidl_typesupport_c rosidl_typesupport_cpp test: --packages-above-and-dependencies rosidl_typesupport_c rosidl_typesupport_cpp)

• Linux
• Linux-aarch64
• Windows

[sloretz]

CI failure involves rosidl_generator_py. I'll look into why it failed with this PR:

15:23:26 LINK : fatal error LNK1181: cannot open input file 'Release\rosidl_generator_py_custom__rosidl_typesupport_c.lib' [C:\ci\ws\build\rosidl_generator_py\rosidl_generator_py_custom__rosidl_generator_py.vcxproj]

[sloretz]

CI re-run

• Linux
• Linux-aarch64
• Windows

[sloretz]

CI LGTM :tada: The windows warning is in rmw_fastrtps and was fixed by https://github.com/ros2/rmw_fastrtps/pull/592