search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

Use target_link_libraries(... PRIVATE ...) in single typesupport case #124

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

This fixes a bug introduced by ros2/rosidl_typesupport#123

target_link_libraries() requires all uses either use the keyword version or the all plain version. #123 updated to the keyword version but missed this spot that's only excercised when a only a single typesupport is used.

I'm able to trigger this bug with:

colcon build --packages-up-to sensor_msgs --packages-ignore rosidl_generator_cpp rosidl_typesupport_cpp rosidl_typesupport_connext_cpp rosidl_typesupport_fastrtps_cpp rosidl_typesupport_introspection_cpp rosidl_runtime_cpp rosidl_typesupport_fastrtps_c rosidl_generator_py

@Blast545 FYI as I'm sure there would be a nightly job or two broken because of this if it weren't for other issues with the Jammy transition.

sloretz commented 2 years ago

CI (build: --packages-up-to sensor_msgs test_msgs test: --packages-select sensor_msgs test_msgs rosidl_typesupport_c rosidl_typesupport_cpp - just FastDDS)

sloretz commented 2 years ago

I need to re-run CI since FastDDS is not a single typesupport RMW anymore https://github.com/ros2/rmw_fastrtps/pull/594#issuecomment-1078293006

sloretz commented 2 years ago

Re-run using just CycloneDDS

sloretz commented 2 years ago

CI - actually just CycloneDDS this time