search

ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

Service introspection #127

Closed ihasdapie closed 1 year ago

ihasdapie commented 1 year ago

This PR is part of a prototype implementation for https://github.com/ros-infrastructure/rep/pull/360 https://github.com/ros2/ros2/issues/1285. It implements the new methods defined in rosidl_runtime_cpp in https://github.com/ros2/rosidl/pull/700 allowing for rcl to populate service_event message payloads.

ihasdapie commented 1 year ago

@jacobperron Pinging to request review & help with changes introduced in https://github.com/ros2/rosidl_typesupport/pull/127/commits/d48c0eec70ea057d536a6cd36afc44777b39e6cc to split typesupport tests into a new package so that we can test the generated typesupport files. I'm stuck on some linker issues while building, so some feedback would be much appreciated.

jacobperron commented 1 year ago

rebased on rolling

ivanpauno commented 1 year ago

lgtm, with test todo's addressed

Tests completed in https://github.com/ros2/rosidl_typesupport/pull/127/commits/f27383168ce98e490813e59ce3bdd82323349b55.

clalancette commented 1 year ago

CI for this is in https://github.com/ros2/ros2/issues/1285#issuecomment-1404070715