ros2 / rosidl_typesupport

Packages which provide the typesupport for ROS messages and services
Apache License 2.0
13 stars 34 forks source link

Fix Typesupport Introspection tests #133

Closed Crola1702 closed 1 year ago

Crola1702 commented 1 year ago

Signed-off-by: Crola1702 cristobal.arroyo@ekumenlabs.com

After (https://github.com/ros2/rosidl_typesupport/pull/127) we have new 2 failing tests in Rolling CycloneDDS:

projectroot.test_service_typesupport_cpp log output:

``` -- run_test.py: invoking following command in '/tmp/ws/build_isolated/rosidl_typesupport_tests': - /tmp/ws/build_isolated/rosidl_typesupport_tests/test_service_typesupport_cpp --gtest_output=xml:/tmp/ws/test_results/rosidl_typesupport_tests/test_service_typesupport_cpp.gtest.xml Running main() from /tmp/ws/install_isolated/gtest_vendor/src/gtest_vendor/src/gtest_main.cc [==========] Running 3 tests from 1 test suite. [----------] Global test environment set-up. [----------] 3 tests from test_service_typesupport [ RUN ] test_service_typesupport.event_message_create_and_destroy_invalid_arguments [ OK ] test_service_typesupport.event_message_create_and_destroy_invalid_arguments (0 ms) [ RUN ] test_service_typesupport.basic_types_event_message_create /tmp/ws/src/ros2/rosidl_typesupport/rosidl_typesupport_tests/test/rosidl_typesupport_cpp/test_service_typesupport.cpp:60: Failure Expected equality of these values: srv_ts->typesupport_identifier Which is: "rosidl_typesupport_introspection_cpp" "rosidl_typesupport_cpp" /tmp/ws/src/ros2/rosidl_typesupport/rosidl_typesupport_tests/test/rosidl_typesupport_cpp/test_service_typesupport.cpp:61: Failure Expected equality of these values: msg_ts->typesupport_identifier Which is: "rosidl_typesupport_introspection_cpp" "rosidl_typesupport_cpp" [ FAILED ] test_service_typesupport.basic_types_event_message_create (0 ms) [ RUN ] test_service_typesupport.fibonacci_action_services_event /tmp/ws/src/ros2/rosidl_typesupport/rosidl_typesupport_tests/test/rosidl_typesupport_cpp/test_service_typesupport.cpp:184: Failure Expected equality of these values: send_goal_event_msg_ts->typesupport_identifier Which is: "rosidl_typesupport_introspection_cpp" "rosidl_typesupport_cpp" /tmp/ws/src/ros2/rosidl_typesupport/rosidl_typesupport_tests/test/rosidl_typesupport_cpp/test_service_typesupport.cpp:185: Failure Expected equality of these values: get_result_event_msg_ts->typesupport_identifier Which is: "rosidl_typesupport_introspection_cpp" "rosidl_typesupport_cpp" [ FAILED ] test_service_typesupport.fibonacci_action_services_event (0 ms) [----------] 3 tests from test_service_typesupport (0 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (0 ms total) [ PASSED ] 1 test. [ FAILED ] 2 tests, listed below: [ FAILED ] test_service_typesupport.basic_types_event_message_create [ FAILED ] test_service_typesupport.fibonacci_action_services_event 2 FAILED TESTS -- run_test.py: return code 1 -- run_test.py: inject classname prefix into gtest result file '/tmp/ws/test_results/rosidl_typesupport_tests/test_service_typesupport_cpp.gtest.xml' -- run_test.py: verify result file '/tmp/ws/test_results/rosidl_typesupport_tests/test_service_typesupport_cpp.gtest.xml' ```

projectroot.test_service_typesupport_c log output:

``` -- run_test.py: invoking following command in '/tmp/ws/build_isolated/rosidl_typesupport_tests': - /tmp/ws/build_isolated/rosidl_typesupport_tests/test_service_typesupport_c --gtest_output=xml:/tmp/ws/test_results/rosidl_typesupport_tests/test_service_typesupport_c.gtest.xml Running main() from /tmp/ws/install_isolated/gtest_vendor/src/gtest_vendor/src/gtest_main.cc [==========] Running 3 tests from 1 test suite. [----------] Global test environment set-up. [----------] 3 tests from test_service_typesupport [ RUN ] test_service_typesupport.event_message_create_and_destroy_invalid_arguments [ OK ] test_service_typesupport.event_message_create_and_destroy_invalid_arguments (0 ms) [ RUN ] test_service_typesupport.basic_types_event_message_create /tmp/ws/src/ros2/rosidl_typesupport/rosidl_typesupport_tests/test/rosidl_typesupport_c/test_service_typesupport.cpp:54: Failure Expected equality of these values: srv_ts->typesupport_identifier Which is: "rosidl_typesupport_introspection_c" "rosidl_typesupport_c" /tmp/ws/src/ros2/rosidl_typesupport/rosidl_typesupport_tests/test/rosidl_typesupport_c/test_service_typesupport.cpp:55: Failure Expected equality of these values: msg_ts->typesupport_identifier Which is: "rosidl_typesupport_introspection_c" "rosidl_typesupport_c" [ FAILED ] test_service_typesupport.basic_types_event_message_create (0 ms) [ RUN ] test_service_typesupport.fibonacci_action_services_event /tmp/ws/src/ros2/rosidl_typesupport/rosidl_typesupport_tests/test/rosidl_typesupport_c/test_service_typesupport.cpp:180: Failure Expected equality of these values: send_goal_event_msg_ts->typesupport_identifier Which is: "rosidl_typesupport_introspection_c" "rosidl_typesupport_c" /tmp/ws/src/ros2/rosidl_typesupport/rosidl_typesupport_tests/test/rosidl_typesupport_c/test_service_typesupport.cpp:181: Failure Expected equality of these values: get_result_event_msg_ts->typesupport_identifier Which is: "rosidl_typesupport_introspection_c" "rosidl_typesupport_c" [ FAILED ] test_service_typesupport.fibonacci_action_services_event (0 ms) [----------] 3 tests from test_service_typesupport (0 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (0 ms total) [ PASSED ] 1 test. [ FAILED ] 2 tests, listed below: [ FAILED ] test_service_typesupport.basic_types_event_message_create [ FAILED ] test_service_typesupport.fibonacci_action_services_event 2 FAILED TESTS -- run_test.py: return code 1 -- run_test.py: inject classname prefix into gtest result file '/tmp/ws/test_results/rosidl_typesupport_tests/test_service_typesupport_c.gtest.xml' -- run_test.py: verify result file '/tmp/ws/test_results/rosidl_typesupport_tests/test_service_typesupport_c.gtest.xml' ```

Reference build: https://build.ros2.org/view/Rci/job/Rci__nightly-cyclonedds_ubuntu_jammy_amd64/351/#showFailuresLink

This PR changes the expected typesupport_identifier so it matches the actual value.

Crola1702 commented 1 year ago

CI:

This CI builds didn't include rosidl_typesupport_tests package

Blast545 commented 1 year ago

@ros-pull-request-builder retest this please

Crola1702 commented 1 year ago

Running CI again:

Crola1702 commented 1 year ago

PR build is failing with a cache error:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 281, in __getitem__
    rawpkg = self._cache[key]
KeyError: 'ros-rolling-service-msgs'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 21, in <module>
    run_module('ros_buildfarm.scripts.devel.create_devel_task_generator', run_name='__main__')
  File "/usr/lib/python3.10/runpy.py", line 227, in run_module
    return _run_code(code, {}, init_globals, run_name, mod_spec)
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/tmp/ros_buildfarm/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 304, in <module>
    sys.exit(main())
  File "/tmp/ros_buildfarm/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 152, in main
    get_binary_package_versions(apt_cache, debian_pkg_names_testing))
  File "/tmp/ros_buildfarm/ros_buildfarm/common.py", line 175, in get_binary_package_versions
    pkg = apt_cache[debian_pkg_name]
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 283, in __getitem__
    raise KeyError('The cache has no package named %r' % key)

How can we install that dependency into the agent? Or is it a missing dependency in general?

FYI: @Blast545 @clalancette

clalancette commented 1 year ago

How can we install that dependency into the agent? Or is it a missing dependency in general?

We're in the middle of a very large rebuild of Rolling. Rpr jobs are probably not going to work at the moment; just depend on CI for now. This should hopefully resolve itself later today.

Crola1702 commented 1 year ago

Running CI:

Crola1702 commented 1 year ago

@clalancette do we need to run RHEL? If not, we're ready to merge

clalancette commented 1 year ago

CI: